Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(primitives): use alloy eth conversion constants #11892

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore(primitives): use alloy eth conversion constants #11892

wants to merge 10 commits into from
+50 −51

Conversation

tcoratger
Copy link
Contributor

No description provided.

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Oct 19, 2024
auto-merge was automatically disabled October 19, 2024 09:48

Head branch was pushed to by a user without write access

onbjerg
onbjerg approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs a rebase though (sorry about that)

@onbjerg onbjerg changed the title primitives: use alloy eth conversion constants chore(primitives): use alloy eth conversion constants Oct 19, 2024
@tcoratger
Copy link
Contributor Author

lgtm, needs a rebase though (sorry about that)

@onbjerg no problem, done :)

onbjerg
onbjerg requested changes Oct 20, 2024
View reviewed changes
crates/ethereum/evm/src/strategy.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg requested changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @onbjerg @mattsse